[Bug 328771] Review Request: babl - A dynamic, any to any, pixel format conversion library

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 12 14:48:32 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: babl - A dynamic, any to any, pixel format conversion library


https://bugzilla.redhat.com/show_bug.cgi?id=328771





------- Additional Comments From dakingun at gmail.com  2007-10-12 10:48 EST -------
(In reply to comment #3)
> There is a dot missing at the end of the devel %description.
>
Will add it.
 
> Also the timestamps are still not kept. As above, I propose:
> make DESTDIR=%{buildroot} install INSTALL='install -p'
>
I don't see why its necessary, the packaging guildeline say to do it, when the
copy command is used. There's no mention of doing it for make install.
  
> The changelog entry is not very clear in my opinion:
> - Remove the use of inexistent source (from package reviews)
A typo, should have been 'inexistent source url'.  Will fix.

> 
> As for shipping babl svn snapshot in F-7 I think that it 
> should be avoided, unless there are severe regression/bugs or 
> there are wonderful new functionalities.
Actually, there are 'wonderful new functionalities' in latest gnome-scan (at
least according to the author), and it depends the svn version of babl and gegl.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list