[Bug 326421] Review Request: xmds - the eXtensible Multi-Dimensional Simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmds - the eXtensible Multi-Dimensional Simulator


https://bugzilla.redhat.com/show_bug.cgi?id=326421


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-10-13 10:51 EST -------
The source should be an url to the upstream source.
See:
http://fedoraproject.org/wiki/Packaging/SourceURL

You should also certainly have a look at the guidelines
if you haven't already:
http://fedoraproject.org/wiki/Packaging/Guidelines

A buildrequires for fftw is missing. It seems to be fftw2-devel,
more precisely.

loadxsil.m shouldn't be in %_bindir, it may better be in 
%doc since there is no specific directory for matlab scripts
currently in fedora.

Docs are missing. Without doc, the package is not very useful. 
There is an example directory, it should be shipped in %doc.
Also the manual would be a must, if it is covered by a free
documentation license.

scilab and matlab are not part of fedora. But unless I am 
wrong, the .dat created by xsil2graphics -s are simple ascii
output file that may be used with any plotting program? Maybe
this could be said somewhere?

In summary it is unneeded to repeat the package name.

Unless I am wrong, xsil2graphics and loadxsil are useful by 
themselves, maybe they could be in a subpackage, since
as far as I can tell from a quick browsing, there aren't many
other xsil tools.

I suggest using %dist since this is a binary package. Also 
why use a release of 3 in the submission, why not begin with 
1?

It seems to me that a requires on gcc-c++ would be in 
order, since it is called during model compilation. Same
for fftw2-devel.

Is libxmds.a meant to be used separately from xmds?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.