[Bug 226464] Merge Review: system-config-network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-network


https://bugzilla.redhat.com/show_bug.cgi?id=226464


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-10-17 00:39 EST -------
Review:
+ package builds in mock (development i386).
- rpmlint is Not silent for SRPM but Not for RPM.
system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8
=> I hope you will take care this message while building package next time.
system-config-network.noarch: W: obsolete-not-provided rp3
=>This messages can be ignored for this package.
system-config-network.src: W: strange-permission system-config-network.spec 0600
=> I hope you will take care this message while building package next time.
+ source files match upstream.
9566acdbecea85601ecc39c71a3e24fa  system-config-network-1.4.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop files are handled correctly.
+ package system-config-network-1.4.4-1.fc8 ->
  Provides: internet-config = 0.40-2.1 isdn-config = 0.18-10.70.1
redhat-config-network = 1.4.4
  Requires: /usr/bin/python gnome-python2 gnome-python2-canvas pygtk2
pygtk2-libglade system-config-network-tui = 1.4.4-1.fc8 usermode
+ package system-config-network-tui-1.4.4-1.fc8 ->
  Provides: config(system-config-network-tui) = 1.4.4-1.fc8 netcfg = 2.36-3p.1
netconf = 0.1-1.1 redhat-config-network-tui = 1.4.4
  Requires: /bin/sh /usr/bin/python config(system-config-network-tui) =
1.4.4-1.fc8 initscripts >= 0:5.99 kudzu newt-python pciutils python rhpl >=
0:0.193 rpm-python usermode
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.