[Bug 250634] Review Request: perl-Mail-DKIM - Perl module for DKIM support

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 17 16:01:04 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request:  perl-Mail-DKIM -   Perl module for DKIM support


https://bugzilla.redhat.com/show_bug.cgi?id=250634


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu




------- Additional Comments From cweyl at alumni.drew.edu  2007-10-17 12:01 EST -------
A couple comments from looking at the spec file:

Perl deps are specified by module, rather than by the name of the package that
provides the required module.  e.g., where your package buildrequires 
perl-ExtUtils-MakeMaker, it should buildrequire perl(ExtUtils::MakeMaker)
instead.  See
https://fedoraproject.org/wiki/PackagingDrafts/Perl#requiresandprovides

There look to be a number of files ripe for inclusion in %doc, namely README,
Change*, HACKING.dkim, scripts/, t/, etc, etc; why not include those in %doc?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list