[Bug 331651] Review Request: ltsp-server-utils - LTSP5 server-side utilities for thin-client chroots/boot images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltsp-server-utils - LTSP5 server-side utilities for thin-client chroots/boot images


https://bugzilla.redhat.com/show_bug.cgi?id=331651


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-10-18 04:31 EST -------
Timestamps on README should be kept, with
cp -p %{SOURCE1} .

in %install, sysconfdir should be treated like other dirs (my bad),
(and same for var):
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
cp -a etc/* $RPM_BUILD_ROOT%{_sysconfdir}

Still unowned directories
/tftpboot/ltsp5/pxe/
/var/opt/ltsp5/

Requires on /sbin/restorecon missing.

Both ltsp-update-kernels and ltsp-build-client should be arranged
to be able to build more than one arch (maybe by being wrapped in 
another script).

It seems to me that ltsp-initialize should call ltsp-build-client
and ltsp-update-kernels.

A dot at the end of the %description is missing.

Also the pxelinux.0 should have a -p and a comment explaining
why it is not possible to have a link.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.