[Bug 317581] Review Request: ruby-rpm - Ruby bindings for RPM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-rpm - Ruby bindings for RPM


https://bugzilla.redhat.com/show_bug.cgi?id=317581


dlutter at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |MODIFIED
               Flag|needinfo?(dlutter at redhat.com|
                   |)                           |




------- Additional Comments From dlutter at redhat.com  2007-10-19 18:51 EST -------
I have addressed the first two issues.
Spec: http://people.redhat.com/dlutter/yum/spec/ruby-rpm.spec
SRPM: http://people.redhat.com/dlutter/yum/SRPMS/ruby-rpm-1.2.3-3.src.rpm

> Well, for 1.2.3-2:
> 
> * File dependency
> -----------------------------------------------------
> BuildRequires: /usr/include/popt.h
> -----------------------------------------------------

Fixed.

> * SourceURL
>   - It seems that "20469" should be "26403"
>   - However 
>     http://rubyforge.org/frs/download.php/26403/ruby-rpm-1.2.3.tgz
>     seems different from the tarball in your srpm?
>   ! Well, for rubyforge.org, the number like "26403" 
>     seems to change every time new version is released.

Yeah, rubyforge has this annoying habit of inserting a random number into the
URL. Fixed.

> * Encoding
> -----------------------------------------------------
> Forgot to mention: the only warning I get from rpmlint is
>    W: file-not-utf8 /usr/share/doc/ruby-rpm-1.2.3/doc/refm.rd.ja
> 
> Any idea what encoding that file is ? (I don't know any Japanese, so I won't
> know if I recoded anything right)
> -----------------------------------------------------
>   - This file is encoded in EUC-JP (well, I am a Japanese)
>     (Many Japanese documents in *nix are encoded in EUC-JP or
>      ISO-2022-JP, and many Japanese documents in M$ are encoded
>      in SHIFT-JIS).

recode EUC-JP..UTF-8 refused to work on this file. For now, it's unchanged. not
sure if it's readable for a Japanese reader.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.