[Bug 251611] Review Request: perl-Template-Alloy - TT2/3, HT, HTE, Tmpl, and Velocity Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Template-Alloy - TT2/3, HT, HTE, Tmpl, and Velocity Engine
Alias: perl-Template-Alloy

https://bugzilla.redhat.com/show_bug.cgi?id=251611


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-10-23 19:18 EST -------
Looks good to me.  The Summary: is terribly cryptic, though.  I know it's what
upstream uses as their summary, but perhaps it would be nicer to say something
like "Fast templating engine supporting the syntax of several other templating
systems" except that's too long.  Ugh.  I'll leave it up to you.

* source files match upstream:
   d55664bbe5389afef51a66a07252a335d8370b2e72f3d494d147d14d05253155  
   Template-Alloy-1.007.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
? summary is somewhat cryptic.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane; full list at the end.
* %check is present and all tests pass:
   All tests successful.
   Files=9, Tests=2992,  3 wallclock secs ( 3.14 cusr +  0.28 csys =  3.42 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Full provides and requires:
   perl(Template::Alloy) = 1.007
   perl(Template::Alloy::Compile)
   perl(Template::Alloy::Context)
   perl(Template::Alloy::EvalPerlHandle)
   perl(Template::Alloy::Exception)
   perl(Template::Alloy::HTE)
   perl(Template::Alloy::Iterator)
   perl(Template::Alloy::Operator)
   perl(Template::Alloy::Parse)
   perl(Template::Alloy::Perl)
   perl(Template::Alloy::Play)
   perl(Template::Alloy::TT)
   perl(Template::Alloy::Tmpl)
   perl(Template::Alloy::VMethod)
   perl(Template::Alloy::Velocity)
   perl(Template::Alloy::_ContextStash)
   perl-Template-Alloy = 1.007-1.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Template::Alloy)
   perl(Template::Alloy::Context)
   perl(Template::Alloy::Exception)
   perl(Template::Alloy::Iterator)
   perl(Template::Alloy::Operator)
   perl(Template::Alloy::VMethod)
   perl(base)
   perl(strict)
   perl(vars)
   perl(warnings)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.