[Bug 346121] Review Request: malaga - Programming language for modelling of language-dependent grammatical information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: malaga - Programming language for modelling of language-dependent grammatical information


https://bugzilla.redhat.com/show_bug.cgi?id=346121





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-25 04:23 EST -------
For 7.11-0.2:

(In reply to comment #2) 
> > - debuginfo must not be empty.
> 
> NOT fixed. Upstream Makefile calls install -s, how do I remove it? Do I need to
> make a patch for it, or rather Makefile.in? 
  - You have to apply a patch against Makefile.in (before configure).
    Alternative way is
-----------------------------------------------------------------
$ sed -i.strip -e 's| -s | |' Makefile.in
-----------------------------------------------------------------
    at the end of %prep.

> > - Please remove static archive.
> 
> If you mean %{_libdir}/libmalaga.a in -devel, if I remove that, rpmbuild
> complains and won't build the packages. How do I go around it then?
  - Actually remove this static archive before %install finishes
   (by "rm -f", for example) and remove this entry from %files.

This time I tried to rebuild this packge, then several
more problems are found.
* build log more verbosely
  - The output like
----------------------------------------------------------------
Compiling avl_trees.c
----------------------------------------------------------------
    is not useful.
    - For example, we want to check if fedora specific compilation
      flags are correctly honored from build.log
    Please make build procedure more verbose. To do so, please remove
    @ (at-mark)s which suppress build process output from Makefile.in.
    For example:
----------------------------------------------------------------
sed -i.debug -e 's|^\([ \t][ \t]*\)@|\1|' Makefile.in
----------------------------------------------------------------

  - Also, it is preferred that you make libtool output more verbose like:
----------------------------------------------------------------
sed -i.silent -e 's|--silent||' Makefile.in
----------------------------------------------------------------
    to check if -fPIC is passed correctly, for example.

* linkage against libmalaga.so
  - The installed binaries in malaga don't use libmalaga.so (
    is not linked against libmalaga.so).

    For example:
----------------------------------------------------------------
$ ldd -r ./malsym
        linux-gate.so.1 =>  (0x00110000)
        libglib-2.0.so.0 => /lib/libglib-2.0.so.0 (0x00ad2000)
        libc.so.6 => /lib/libc.so.6 (0x007d6000)
        /lib/ld-linux.so.2 (0x007b7000)
----------------------------------------------------------------
    build log says:
----------------------------------------------------------------
Linking malsym
gcc  avl_trees.o basic.o files.o hangul.o malaga_files.o malsym.o pools.o
scanner.o sym_compiler.o symbols.o tries.o values.o -lglib-2.0   -o malsym
----------------------------------------------------------------
    where
----------------------------------------------------------------
gcc -shared  .libs/analysis.o .libs/avl_trees.o .libs/basic.o .libs/cache.o
.libs/commands.o .libs/display.o .libs/files.o .libs/hangul.o .libs/input.o
.libs/lexicon.o .libs/malaga_files.o .libs/malaga_lib.o .libs/options.o
.libs/patterns.o .libs/pools.o .libs/processes.o .libs/rules.o .libs/scanner.o
.libs/symbols.o .libs/transmit.o .libs/tries.o .libs/value_parser.o
.libs/values.o .libs/libmalaga.o  -lglib-2.0 -lm  -Wl,-soname -Wl,libmalaga.so.7
-o .libs/libmalaga.so.7.0.0
----------------------------------------------------------------
    so almost all objects used in malsym are in libmalaga.so.

Extras issues:
- Redundant Requires:
  "Requires: gtk2" is not needed. rpmbuild checks dependencies for
   libraries and automatically adds those dependency to binary rpms.

- Timestamps
  - Add 
----------------------------------------------------------------
INSTALL="install -p"
----------------------------------------------------------------
    option to "make install" to keep timestamps on installed files.
    This method usually works for recent Makefiles.

* Permission
  - Permission of libmalaga.so must be 0755, not 0644
  ! Don't use %attr. Change the permission of file before %install
    section ends so that this libraries can be stripped by
    rpmbuild.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.