[Bug 346241] Review Request: ruby-ldap - Ruby LDAP libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-ldap - Ruby LDAP libraries


https://bugzilla.redhat.com/show_bug.cgi?id=346241


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-10-28 08:49 EST -------
For 0.9.7-1:

* rdoc dependency
  - Would you explain why this package should have 
    (Build)Requires: ruby-ldap?

* Redundant Requires
  - "Requires: openldap openssl" is not needed. rpmbuild checks
     libraries' dependency and automatically adds it to binary rpms.

* SourceURL
  - For sourceforge tarball, please follow:
    http://fedoraproject.org/wiki/Packaging/SourceURL

* Stripping binaries
  - Stripping binaries by yourself is not allowed because this makes
    it impossible to create debuginfo rpm.

* Timestamp
  - For this package you can (should) use INSTALL="install -p" option to
    make install to keep timestamps on installed .rb files.

* %check
  - What is this empty %check entry for?
    * By the way, subdirectory test/ exists in tarball.
      If possible, please execute some tests in %check section.

* File entry
  - On i386
---------------------------------------------------------------------
warning: File listed twice: /usr/lib/ruby/site_ruby/1.8/i386-linux/ldap.so
---------------------------------------------------------------------
    ruby_sitelib points to /usr/lib/ruby/site_ruby/1.8,
    ruby_sitearch points to /usr/lib/ruby/site_ruby/1.8/i386-linux (on i386),
    so the file above is listed twice. Please avoid this.

  ! Note: on x86_64,
    ruby_sitelib points to /usr/lib/ruby/site_ruby/1.8, where
    ruby_sitearch points to /usr/lib64/ruby/site_ruby/1.8/x86_64-linux.

* Documents
  - You may also want to add "FAQ" to %doc.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.