[Bug 243665] Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Geo-IP - Efficient GeoIP bindings for Perl


https://bugzilla.redhat.com/show_bug.cgi?id=243665


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-09-02 13:15 EST -------
OK, now I finally have some time.

This all looks good to me now, except for one thing.  When you apply patch1, the
backup file is left in there and installed:

E: perl-Geo-IP wrong-script-interpreter
/usr/share/doc/perl-Geo-IP-1.28/example/netspeed.pl.netspeed "/usr/local/bin/perl"

It should be trivial to nuke this or to remove the "-b .netspeed" bit. 
Otherwise  everything looks good, and to avoid another round trip I'll just
approve this now and you can fix the issue when you check in.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.