[Bug 275281] Review Request: gimmage - A Simple GNOME Image Viewer
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 4 14:45:39 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gimmage - A Simple GNOME Image Viewer
https://bugzilla.redhat.com/show_bug.cgi?id=275281
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-09-04 10:45 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMs.
+ source files match upstream.
f51cca53b3d33415e75a91cf81b6ac39 gimmage-0.2.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc files are present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ Desktop files installed correctly.
+ file permissions are appropriate.
+ update-desktop-database scriptlets used.
+ Package gimmage-0.2.3-3.fc8 ->
Requires: libatk-1.0.so.0 libatkmm-1.6.so.1 libc.so.6 libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2)
libc.so.6(GLIBC_2.4) libcairo.so.2 libcairomm-1.0.so.1 libcurl.so.4 libdl.so.2
libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0
libgdkmm-2.4.so.1 libglib-2.0.so.0 libglibmm-2.4.so.1 libgmodule-2.0.so.0
libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libgtkmm-2.4.so.1 libm.so.6
libmagic.so.1 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangomm-1.4.so.1
libsigc-2.0.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)
+ GUI App.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list