[Bug 269941] Review Request: gmyth - MythTV remote access libraries

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 6 14:59:28 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gmyth - MythTV remote access libraries


https://bugzilla.redhat.com/show_bug.cgi?id=269941





------- Additional Comments From bnocera at redhat.com  2007-09-06 10:59 EST -------
(In reply to comment #3)
> Preliminary comments: 
> 
> devel should require %{name} = %{version}-%{release}

I don't really agree with that one, but I fixed it anyway.

> devel needs to require pkgconfig

And glib2-devel, mysql-devel and curl-devel, otherwise it won't link...

> could use %{?_smp_mflags}, maybe

Fixed.

> should use %{_includedir} in the file list

Don't know how I didn't see that.

http://people.redhat.com/bnocera/gmyth/gmyth.spec
http://people.redhat.com/bnocera/gmyth/gmyth-0.4-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list