[Bug 278481] Review Request: linuxdcpp - Client for the direct connect protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Client for the direct connect protocol


https://bugzilla.redhat.com/show_bug.cgi?id=278481





------- Additional Comments From opensource at till.name  2007-09-08 02:25 EST -------
- rpmlint: NEEDSWORK
W: linuxdcpp rpm-buildroot-usage %build scons PREFIX=%{_prefix}
FAKE_ROOT=$RPM_BUILD_ROOT release=0
It seems you can skip FAKE_ROOT=$RPM_BUILD_ROOT in %build, than rpmlint will be
silent. I do not know scons, but SConstruct uses FAKE_ROOT only in its install
section.

- licenses: NEEDSWORK
You used GPLv2 in License, but when I look in the source, nearly every file hast
a GPLv2+ header.

- naming: ok
- license in %doc: ok
- spec legible: ok
- compiling:builds for all supported architectures:ok
- BuildRequires: ok
- locales: not used: ok
- ldconfig: not needed: ok
- directory ownage: ok, todo
Please use %{_datadir}/linuxdcpp/ in %files to make it visible, that it is a
directory
- %clean, %install rm -rf: ok
- BuildRoot: ok
- no -devel or -static subpackage: ok

TODO (by me):
- Verify .desktop file
I do not yet know, how to verify whether or not StartupNotify and/or
StartupWMClass should be used. I have to do some research here.
- Verify tarball creation

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.