[Bug 246387] Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libibcommon - OpenFabrics Alliance InfiniBand management common library


https://bugzilla.redhat.com/show_bug.cgi?id=246387


opensource at till.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From opensource at till.name  2007-09-08 09:22 EST -------
This is not a valid value for the License Tag:
License: GPL/BSD
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#head-f21ae23bf2f278444e2c385463cfa74a502396b8


This is afaik not needed:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

Because this already creates the Requires:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig


I am not sure, is the -static subpackage useful without the -devel package? If
not, then the -static package should depend on the -devel package and not on the
main package.


%install must begin with "rm -rf $RPM_BUILD_ROOT"


This
%{_includedir}/infiniband/*.h
should be
%{_includedir}/infiniband/
to include the directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.