[Bug 253910] Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksirk - Turnbased multiplayer board strategy game (conquer the world!)


https://bugzilla.redhat.com/show_bug.cgi?id=253910





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-09-08 11:46 EST -------
(In reply to comment #1)
> rpmlint is clean on RPM, but on SRPM: 
> 
> ksirk.src:35: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.la
> A library path is hardcoded to one of the following paths: /lib,
> /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
> 
> ksirk.src:39: E: hardcoded-library-path in %{_prefix}/lib/lib%{name}_*.so
> A library path is hardcoded to one of the following paths: /lib,
> /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.
> 

These get caused by these lines in the spec:
rm $RPM_BUILD_ROOT%{_prefix}/lib/lib%{name}_*.la
# these are unversioned libs, which are only used by ksirk itself
mkdir -p $RPM_BUILD_ROOT%{_libdir}/%{name}
mv $RPM_BUILD_ROOT%{_prefix}/lib/lib%{name}_*.so \
  $RPM_BUILD_ROOT%{_libdir}/%{name}

Which move the lib from /usr/lib (wrong on 64 bit) to
%{_libdir}/%{name}, so the lines causing the warning actually fix the issue
reported by rpmlint :) Without these lines rpmlint won't complain and the result
will be wrong.

> Also, I see shared libs, but no ldconfig in post or postun.
> 

Correct, the .so files are only for ksirk and are unversioned, thus they get
installed in %{_libdir}/%{name} not just %{_libdir}. So ldconfig is not needed
(and would have no effect as it doesn't look in %{_libdir}/%{name} only in
%{_libdir} ).


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.