[Bug 226223] Merge Review: ORBit2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ORBit2


https://bugzilla.redhat.com/show_bug.cgi?id=226223





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-09-10 04:02 EST -------
For 2.14.7-6:

* License
  - Please recheck the license
    * Most source codes do not specify any version and
      it seems that source codes which contain license term contain
      "and any later" term. So at least this can be
      "LGPLv2+ and GPLv2+"

* Redundant requires
  - For devel
--------------------------------------------------
Requires: glib2-devel
Requires: glib2-devel >= %{glib2_version}
--------------------------------------------------
    The first line can be omitted.

* Parallel make
  - Support parallel make when possible.

* %makeinstall
  - Please avoid %makeinstall when possible.
  - Usually I recommend
--------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
--------------------------------------------------
    for recent Makefile. This will keep timestamps on
    most files

* Directory ownership issue
  - Please fix up directory ownership issue.
--------------------------------------------------
    %_libdir/orbit-2.0 - must owned by main, not by devel
    %_datadir/idl - must owned by ORBit2-devel, not by
                    libbonobo-devel

* Defattr
  - Now we recommend %defattr(-,root,root,-)

* Rpmlint
  - file-not-utf8 /usr/share/doc/ORBit2-2.14.7/NEWS
    * Please change the encoding to UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.