[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz


https://bugzilla.redhat.com/show_bug.cgi?id=253692


wtogami at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wtogami at redhat.com




------- Additional Comments From wtogami at redhat.com  2007-09-14 16:33 EST -------
The package looks fine, except the %post, %pre, and %preun scriptlets.

1) Do you really intend on doing --makefile-install-rule in all three places? 
Probably not.
2) You should avoid difficult-to-maintain long lists of plugins that are
redundant in the three scriptlets.  You could do something like the compiz
package with:

%define         core_plugins    blur clone cube dbus decoration fade ini inotify
minimize move

for f in %{core_plugins}; do
  echo %{_libdir}/compiz/lib$f.so
  echo %{_datadir}/compiz/$f.xml
done >> core-files.txt

Then use a loop within the scriptlets to install or uninstall the schemas.
export GCONF_CONFIG_SOURCE=`/usr/bin/gconftool-2 --get-default-source`
for f in %{core_plugins} %{gnome_plugins} core; do
  gconftool-2 --makefile-install-rule
%{_sysconfdir}/gconf/schemas/compiz-$f.schemas >& /dev/null || :
done


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.