[Bug 293801] Review Request: xorg-x11-drv-avivo - Xorg driver for ATI R500+

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-avivo - Xorg driver for ATI R500+


https://bugzilla.redhat.com/show_bug.cgi?id=293801





------- Additional Comments From notting at redhat.com  2007-09-18 00:23 EST -------
MUST items:
 - Package meets naming and packaging guidelines - ***

Consider using some sort of versioning on the snapshot.

 - Spec file matches base package name. - OK
 - Spec has consistant macro usage. - OK
 - Meets Packaging Guidelines. - OK
 - License - OK
 - License field in spec matches - ****

>From a quick examination, GPLv2 is the correct value for the license tag.
Although avivotool is lacking in licensing in the code.

 - License file included in package - OK
 - Spec in American English - OK
 - Spec is legible. - OK
 - Sources match upstream md5sum: - *** Can't check due to snapshot. 
 - Package needs ExcludeArch - OK
 - BuildRequires correct - ***

BuildRequires:  libpciaccess-devel
  and
%configure --disable-pciaccess

seem contradictory. Other than that, looks OK (it builds.)

 - Spec handles locales/find_lang - N/A
 - Package is relocatable and has a reason to be. - N/A
 - Package has %defattr and permissions on files is good.  - OK
 - Package has a correct %clean section. - OK
 - Package has correct buildroot - OK
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 - Package is code or permissible content. - OK
 - Doc subpackage needed/used. - N/A
 - Packages %doc files don't affect runtime. - OK
 - Headers/static libs in -devel subpackage. - N/A
 - Spec has needed ldconfig in post and postun - N/A
 - .pc files in -devel subpackage/requires pkgconfig - N/A
 - .so files in -devel subpackage. - N/A
 - -devel package Requires: %{name} = %{version}-%{release} - N/A
 - .la files are removed. - OK
 
 - Package is a GUI app and has a .desktop file - N/A

 - Package compiles and builds on at least one arch. - OK (tested: i386 (mock),
x86_64 (local))
 - Package has no duplicate files in %files. - OK
 - Package doesn't own any directories other packages own. - OK
 - Package owns all the directories it creates. - OK
 - No rpmlint output. ***

xorg-x11-drv-avivo.i386: W: invalid-license GPL - covered above

 - final provides and requires are sane:

$ rpm -qpR xorg-x11-drv-avivo-0.0.1-3.fc8.i386.rpm 
libc.so.6  
...
libpciaccess.so.0  
rpmlib(CompressedFileNames) <= 3.0.4-1
...

implies that %configure --disable-pciaccess doesn't actually work.

SHOULD Items:

 - Should build in mock. - OK (tested: i386)
 - Should build on all supported archs - tested i386, x86_64
 - Should function as described. - can't test, no hardware
 - Should have sane scriptlets. - OK
 - Should have subpackages require base package with fully versioned depend. - N/A
 - Should have dist tag - OK
 - Should package latest version - ***

Can't tell from snapshot.

So, absolutely needs fixed:
- license tag

Really useful to have fixed:
- versioning of tarball, package

Might want to fix:
- libpciaccess confusion
- add a .xinf file?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.