[Bug 290011] Review Request: roxterm - A fast terminal emulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: roxterm - A fast terminal emulator


https://bugzilla.redhat.com/show_bug.cgi?id=290011





------- Additional Comments From panemade at gmail.com  2007-09-19 02:55 EST -------
mock build is successful. 
But, need some changes for %doc
make following line 
%doc AUTHORS ChangeLog COPYING NEWS
%doc %{_datadir}/doc/roxterm/*
%{_bindir}/roxterm
%{_bindir}/roxterm-config
%{_datadir}/applications/fedora-roxterm.desktop
%{_datadir}/roxterm/*
%{_datadir}/icons/hicolor/scalable/apps/roxterm.svg

to
%doc %{_datadir}/doc/roxterm
%{_bindir}/roxterm
%{_bindir}/roxterm-config
%{_datadir}/applications/fedora-roxterm.desktop
%{_datadir}/roxterm
%{_datadir}/icons/hicolor/scalable/apps/roxterm.svg

but this looks like that we are getting following docdir
/usr/share/doc/roxterm but not /usr/share/doc/roxterm-1.7.4
you can use --docdir=%{_docdir}/%{name}-%{version} to ./configure

Use consistent macro style.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.