[Bug 233775] Review Request: haproxy - TCP/HTTP reverse proxy for high availability environments

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: haproxy - TCP/HTTP reverse proxy for high availability environments


https://bugzilla.redhat.com/show_bug.cgi?id=233775





------- Additional Comments From kevin at tummy.com  2007-09-19 22:23 EST -------
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License (GPLv2+)
See below - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
032f976cf82e1ba48702e25545155147  haproxy-1.3.12.1.tar.gz
032f976cf82e1ba48702e25545155147  haproxy-1.3.12.1.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. I think the License tag here should be "GPLv2+ and LGPLv2+ and MIT".
The bulk of the program is under the GPLv2+, but those pesky example bits are
now MIT. Also, many of the header files are LGPLv2+.
It's all nice and confusing. I might try and get spot to look it over. ;)

Also, I am not sure it's permissable to change license's via a patch.
You may need to wait until upstream does a new release with the new
license text in place.

2. rpmlint says (as before):
haproxy.i386: E: non-standard-uid /var/lib/haproxy haproxy
haproxy.i386: E: non-standard-gid /var/lib/haproxy haproxy
Can be ignored.

Everything else looks good, hopefully we can get this approved soon.

Spot: can you take a look at the current license situation?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.