[Bug 292371] Review Request: ladspa-caps-plugins - The C* Audio Plugin Suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ladspa-caps-plugins - The C* Audio Plugin Suite


https://bugzilla.redhat.com/show_bug.cgi?id=292371





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-09-20 14:18 EST -------
(In reply to comment #2)
> By default the new version compiles with:
> 
>   -O2 -ffast-math -funroll-loops -Wall -fPIC -DPIC
> 
> So the extra flags are no longer needed. 
> What I have in %install now is:
> 

Erm, explain? Passing RPM_OPT_FLAGS is always needed to enable things like
FORTIFY_SOURCE and stack-smashing protection, which are not only usefull for
security reasons, but also for catching normal bugs. Normally RPM_OPT_FLAGS
should be the only optimalisation affecting flags, but when upstream uses
-ffast-math, that may be added.

> ----
> %install
> %{__rm} -rf %{buildroot}
> # install x86_64 in the right place
> %{__perl} -p -i -e "s|/lib/|/%{_lib}/|g" Makefile
> %{__make} PREFIX=%{buildroot}%{_prefix} install
> # make sure plugin shared library is executable
> %{__chmod} +x %{buildroot}%{_libdir}/ladspa/caps.so
> ----
> 

My main development machine is a 64 bits machine, and there the spec as
initially posted works fine, did you try the posted SRPM?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.