[Bug 226200] Merge Review: nkf

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: nkf


https://bugzilla.redhat.com/show_bug.cgi?id=226200





------- Additional Comments From panemade at gmail.com  2007-09-21 02:31 EST -------

(In reply to comment #6)
> Sorry, but please wait.
> 
> * Compilation does not honor %optflags
>   http://koji.fedoraproject.org/koji/getfile?taskID=168881&name=build.log
> ------------------------------------------------------
> + make nkf
> cc -O -c utf8tbl.c
> cc -O -o nkf nkf.c utf8tbl.o
> ------------------------------------------------------

  use make CFLAGS="$RPM_OPT_FLAGS"  nkf

> 
> * perl macro
>   - Please use %perl_vendorarch or %perl_vendorlib
  ohh I missed to check perl macors.
> 
> * Timestamp
>   - For SOURCE3, please use "cp -p" to keep timestamp.
   yes. this is still missing in SPEC.
> 
> * defattr
>   - Now we recommend %defattr(-,root,root,-)
   I am still unclear on usage of this as I guess some packagers still prefer
%defattr(-,root,root) bu tI have seen you always asking packagers to use
%defattr(-,root,root,-) but can't find this thing written in packaging guidelines.
> 
> * Using direct command vs using macro command
>   - Please choose if you use write commands directly, or
>     use macros as much as possible.
> 
>     For example, if you want to use %__install_p, you also
>     want to use %__rm, %__cp, %__make, %__chmod.

 I better should look carefully on macros from next time while doing reviews.

Mamoru,
  Thanks for commenting missing things here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.