[Bug 225733] Merge Review: eruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: eruby


https://bugzilla.redhat.com/show_bug.cgi?id=225733


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2007-09-21 10:12 EST -------
Preliminary review
1) rpmlint on SRPM and RPMs gave me
eruby.src:9: W: buildprereq-use ruby
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

eruby.src:10: W: buildprereq-use ruby-devel >= 1.8.0
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

eruby.src: W: mixed-use-of-spaces-and-tabs (spaces: line 76, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

eruby.i386: E: non-standard-dir-perm /usr/share/doc/eruby-1.0.5/examples 02755
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

eruby-libs.i386: W: no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

eruby-libs.i386: E: non-standard-executable-perm
/usr/lib/ruby/1.8/i386-linux/eruby.so 0555
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

eruby-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

eruby-devel.i386: W: no-dependency-on eruby

eruby-devel.i386: W: summary-ended-with-dot Development files for eRuby.
Summary ends with a dot.


SHOULD:
  1)Avoid .a files
  2)use %defattr (-, root, root, -)
  3)Keep consistent usage of macros
     use %__install_p, %__rm, %__cp, %__make, %__chmod.
  4)Can't see License files installed.
  5) Any reason to use eruby-all.files way of installing files in %files section?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.