[Bug 240169] Review Request: llvm - The Low Level Virtual Machine
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 22 03:41:08 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: llvm - The Low Level Virtual Machine
https://bugzilla.redhat.com/show_bug.cgi?id=240169
bugzilla at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Product|Fedora Extras |Fedora
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tibbs at math.uh.edu
------- Additional Comments From tibbs at math.uh.edu 2007-09-21 23:41 EST -------
This deserves a review as llvm is being used all over the place these days.
However, I'm not sure I'm up to tackling this on my own, but I can at least give
it a little attention. Here are a few comments after a quick skim:
URL has a typo (extra period).
Upstream released 2.0 not long after this package was submitted.
The License: tag for the NCSA license is just "NCSA". Other License: tags will
need updating for current licensing guidelines; I think the GCC versions
included are GPLv2+ but I didn't check.
You probably do want to build the documentation in the final package.
The compiler packages seem to meet the naming conventions used by other
cross-compilers (avr-gcc, etc.) so that's OK.
The build fails for me in curent rawhide, although frankly I don't understand
what's up unless the system headers have suddenly become broken:
if g++ -I/builddir/build/BUILD/llvm-1.9/lib/Support
-I/builddir/build/BUILD/llvm-1.9/lib/Support
-I/builddir/build/BUILD/llvm-1.9/include
-I/builddir/build/BUILD/llvm-1.9/include
-I/builddir/build/BUILD/llvm-1.9/include
-I/builddir/build/BUILD/llvm-1.9/include -D_GNU_SOURCE -D__STDC_LIMIT_MACROS
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -D_DEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic -Woverloaded-virtual -pedantic -Wall -W -Wwrite-strings
-Wno-long-long -Wunused -Wno-unused-parameter -c -MD -MT
/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.o -MP -MF
/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.LACXXd
Allocator.cpp -o /builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.o ;\
then /bin/mv -f
"/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.LACXXd"
"/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.d"; \
else /bin/rm -f
"/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.LACXXd"; exit 1; fi
/usr/include/bits/unistd.h: In function 'int gethostname(char*, size_t)':
/usr/include/bits/unistd.h:225: error: declaration of 'int gethostname(char*,
size_t) throw ()' throws different exceptions
/usr/include/unistd.h:845: error: from previous declaration 'int
gethostname(char*, size_t)'
/usr/include/bits/unistd.h: In function 'int getdomainname(char*, size_t)':
/usr/include/bits/unistd.h:243: error: declaration of 'int getdomainname(char*,
size_t) throw ()' throws different exceptions
/usr/include/unistd.h:864: error: from previous declaration 'int
getdomainname(char*, size_t)'
Allocator.cpp: In member function 'void*
llvm::BumpPtrAllocator::Allocate(unsigned int, unsigned int)':
Allocator.cpp:95: warning: dereferencing type-punned pointer will break
strict-aliasing rules
make[1]: *** [/builddir/build/BUILD/llvm-1.9/lib/Support/Release/Allocator.o]
Error 1
I can't say much more without building it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list