[Bug 300651] Review Request: baekmuk-ttf-fonts - Korean truetype fonts (from fonts-korean)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: baekmuk-ttf-fonts - Korean truetype fonts (from fonts-korean)


https://bugzilla.redhat.com/show_bug.cgi?id=300651





------- Additional Comments From petersen at redhat.com  2007-09-23 20:01 EST -------
(In reply to comment #5)
> * Use "-p" option for "cp" or "install" to keep timestamp

Not sure what you mean here: I don't see any cp usage currently in .spec.

> ? So FAPIcidfmap.ko and cidfmap.ko, COPYRIGHT* README are instaled
>   in each subpackage?

Currently, yes.  Installing the CID fmap files in each package is not ideal,
but I can't see a better way without introducing some messy scripts say
and it should not have any particular adverse affects I think.
The %doc files are all small so I don't see a big problem with duplicating
them in each subpackage.

> ? Why can each subpackage have "Provides: ttfonts-ko = %{ttfontverhead}"?
>   I guess only when all subpackages are installed, they can provide
>   "ttfonts-ko = %{ttfontverhead}" for consistency with the state before
>   kkfonts related packages are seperated?

Ok, let me remove the Provides.

> * /etc should be %_sysconfdir

ah yes, thanks

> ? What happens if /usr/bin/fc-cache fails by some reason?

Shrug, I am just using the standard Font scriptlets, but if you want
I can protect the fc-cache invocations in %post and %postun.


Spec URL: http://fedorapeople.org/petersen/baekmuk-ttf/baekmuk-ttf-fonts.spec
SRPM URL:
http://fedorapeople.org/petersen/baekmuk-ttf/baekmuk-ttf-fonts-2.2-3.fc7.src.rpm
[28MB]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.