[Bug 275231] Review Request: php-channel-phing - Adds phing channel to PEAR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-channel-phing - Adds phing channel to PEAR


https://bugzilla.redhat.com/show_bug.cgi?id=275231





------- Additional Comments From fedora at famillecollet.com  2007-09-24 12:03 EST -------
REVIEW 
* no source files
* package meets naming and packaging guidelines (no special guideline for channels).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (LGPLv2).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (F7 - x86_64).
* package installs properly
* rpmlint :
W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 9)
W: php-channel-phpdb no-documentation
* final requires 
php-cli >= 5.1.4
php-pear(PEAR)  
* final provides see below
php-channel(pear.phing.info) = 1.0.0-3.fc8
php-channel-phing = 1.0.0-3.fc8
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 

I don't think you need to requires php-cli >= 5.1.4, why this ?

Should :
correct spec (space/tabs)
Requires(post): %{__pear}
Requires(postun): %{__pear}
Provides: php-channel(pear.phing.info)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.