[Bug 253549] Review Request: TzClock - GTK+ Time Zone Clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TzClock - GTK+ Time Zone Clock


https://bugzilla.redhat.com/show_bug.cgi?id=253549


rafalzaq at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |rafalzaq at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From rafalzaq at gmail.com  2007-09-28 09:40 EST -------
Above link is broken so I use this one:
http://www.theknight.co.uk/releases/tzclock-2.5.4-1.src.rpm

* rpmlint is not silent:
tzclock-debuginfo.x86_64: E: empty-debuginfo-package
tzclock.src: E: invalid-spec-name TzClock.spec
* you should use %{?dist} macro in Release tag
* package fails to build in mock; missing BR: libgnomeui-devel
* you should include AUTHORS and COPYING files in %doc
* IMO you should change all names to lowercase to improve usability
* IANAL but this doesn't look like GPLv2
/*----------------------------------------------------------------------------------------------------*
 *                                                                             
                      *
 *  T Z  C L O C K  G T K . C                                                  
                      *
 *  =========================                                                  
                      *
 *                                                                             
                      *
 *  All rights reserved. Reproduction, modification, use or                    
                      *
 *  disclosure to third parties without express authority is                   
                      *
 *  forbidden. Copyright Teligent AB, Sweden, 2006.                            
                      *
 *                                                                             
                      *
 *----------------------------------------------------------------------------------------------------*/



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.