[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 439911] Review Request: stringtemplate - A Java template engine



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: stringtemplate - A Java template engine


https://bugzilla.redhat.com/show_bug.cgi?id=439911


tibbs math uh edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs math uh edu  2008-04-04 20:13 EST -------
This seems to have cropped up, or did I somehow miss it earlier:
  stringtemplate.src:42: W: rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT
Normally you don't need to erase the build root in %build, because it should be
empty before %install.  Why do you need to do that?

Otherwise, things look good:

The license text is present.
The dependencies look correct:
  stringtemplate-3.1-1.fc9.noarch.rpm
   stringtemplate = 3.1-1.fc9
  =
   java >= 1:1.6.0
   jpackage-utils

  stringtemplate-javadoc-3.1-1.fc9.noarch.rpm
   stringtemplate-javadoc = 3.1-1.fc9
  =
   java-javadoc

%check is now present, and the tests pass:
    [junit] Tests run: 279, Failures: 0, Errors: 0, Time elapsed: 0.28 sec

So, because another round trip probably isn't productive, I'll approve this on
the condition that you remove the "rm -rf $RPM_BUILD_ROOT" bit from %build.  Or,
if you need it for something, let's investigate why.

APPROVE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]