[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Bug 321411] Review Request: ski - IA-64 user and system mode simulator

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ski - IA-64 user and system mode simulator


------- Additional Comments From dan danny cz  2008-04-09 05:26 EST -------
(In reply to comment #9)
> This is looking good.
> You can get dir of the unused-direct-shlib-dependency complaints with another
libtool hack:
>   sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool
> Since you're already hacking up libtool a bit, there's probably no reason not
to do that as well (unless it breaks something, I guess).

Thanks for the libtool trick, it is included and nothing looks broken.

> The remaining rpmlint complaints are:
>   ski-devel.x86_64: W: no-documentation
> Not a problem.
>   ski-devel.x86_64: W: no-dependency-on ski
> The -devel package depends on the -lib package, but not the main package. 
This also is not a problem.
> Most packages seem to use "-libs" for the library subpackage, but there are a
> few who use "-lib" and we don't seem to have any guidelines about it, so
> that's OK.

Oh, I surely wanted to use -libs ;-)

> There's a test suite in the "testsuite" directory; is this something which
> could be run at build time?

It doesn't  look like it is easily runnable and even it doesn't test something
much useful.

> Note that there's no need to include the COPYING twice.  Just having it in the
> main package is sufficient, even if it's possible to install the software
> without installing that package.  This isn't a blocker, though.

I would like to include both of them.

* Wed Apr  9 2008 Dan Horak <dan[at]danny.cz> 1.3.2-3
- fix linking issues
- use -libs for the subpackage

Spec URL: http://fedora.danny.cz/ski.spec
SRPM URL: http://fedora.danny.cz/ski-1.3.2-3.fc9.src.rpm

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]