[Bug 416471] Review Request: xsel -- manipulate the X selection

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsel -- manipulate the X selection


https://bugzilla.redhat.com/show_bug.cgi?id=416471





------- Additional Comments From pertusus at free.fr  2008-04-12 08:29 EST -------
The Source should be the url leading to the real file, like

Source0:
http://www.vergenet.net/~conrad/software/xsel/download/xsel-%{version}.tar.gz

Also the Url should better be like:

Url: http://www.vergenet.net/~conrad/software/xsel/
which leads to the package home page and description.

License looks like MIT (old style), looking at the web page
http://fedoraproject.org/wiki/Licensing/MIT

For packaged releases (unlike snapshots), you shouldn't have the BuildRequires
libtool, autoamke and autoconf (you can simply comment them out in case using
svn snapshots is often useful for that package).

The requires for the Xserver is certainly wrong, unless this program requires a
real X server and not the X abstraction (like the one provided by the ssh X
redirection or vnc, or a real X server). 

You should use the rpm macro
%configure 
instead of doing it yourself.

The make call that does the compilation should be done in the %build and not in
%install.

You should remove the package name from the summary, all the tools should use
the name if needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.