[Bug 226302] Merge Review: pm-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pm-utils


https://bugzilla.redhat.com/show_bug.cgi?id=226302





------- Additional Comments From opensource at till.name  2008-04-15 07:36 EST -------
(In reply to comment #12)

> 2. Why is pkgconfig BuildRequires there?

This will be removed (also all other BRs). Maybe they were all needed for
vbetool or radeontool, which now are in their own packages.
 
> 3. Should there be a Requires: pam?

pm-utils requires usermode which requires pam.

> 5. Why is there a
> Conflicts: bluez-utils < 2.25-6
> ? Shouldn't you just require the newer one?

This will be removed, too.

> pm-utils.i686: W: symlink-should-be-relative /usr/sbin/pm-hibernate
> /usr/lib/pm-utils/bin/pm-action
> pm-utils.i686: W: symlink-should-be-relative /usr/sbin/pm-suspend-hybrid
> /usr/lib/pm-utils/bin/pm-action
> pm-utils.i686: W: symlink-should-be-relative /usr/sbin/pm-suspend
> /usr/lib/pm-utils/bin/pm-action

I do not know how to do this directly in automake, I will see what we can do
about this at upstream.

> pm-utils.i686: W: non-conffile-in-etc /etc/security/console.apps/pm-suspend-hybrid
> pm-utils.i686: W: non-conffile-in-etc /etc/security/console.apps/pm-hibernate
> pm-utils.i686: W: non-conffile-in-etc /etc/pam.d/pm-hibernate
> pm-utils.i686: W: non-conffile-in-etc /etc/pam.d/pm-suspend-hybrid
> pm-utils.i686: W: non-conffile-in-etc /etc/pam.d/pm-suspend
> pm-utils.i686: W: non-conffile-in-etc /etc/pam.d/pm-powersave
> pm-utils.i686: W: non-conffile-in-etc /etc/security/console.apps/pm-suspend
> pm-utils.i686: W: non-conffile-in-etc /etc/security/console.apps/pm-powersave

I am not sure, whether these file are intended to be edited by anyone, half of
them are empty, anyways. Maybe it is even completely wrong to allow users to run
pm-utils directly, so these files can be removed.

> pm-utils.i686: W: log-files-without-logrotate /var/log/pm-suspend.log

The logfile will be emptied on every run, so there is no need to rotate it.

> pm-utils.i686: W: dangerous-command-in-%pre mv
> pm-utils.i686: W: dangerous-command-in-%post mv
> 
> What are you trying to do in that pre? It looks odd.

The scriptlets move the old config files to the new locations, I guess they can
be removed when F9 is branched, because then every release should already have
had the new pm-utils.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.