[Bug 442854] Review Request: psiconv : A conversion utility for Psion files
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 17 09:23:20 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: psiconv : A conversion utility for Psion files
https://bugzilla.redhat.com/show_bug.cgi?id=442854
------- Additional Comments From j.w.r.degoede at hhs.nl 2008-04-17 05:23 EST -------
Full review done:
MUST FIX:
---------
-Missing BuildRequires: ImageMagick-devel bc
-The man page for psiconv-config should be in -devel
-The doc files under /usr/share/psiconv should be moved to %doc of
-devel, iow do this after make install:
mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
And then add: " %doc _doc/*" to %files of -devel
-License should be GPLv2+ not GPLv2 as far as I can see, any particular reason
you've used GPLv2?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list