[Bug 438039] Review Request: GMT-coastlines - Coastline data for GMT

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: GMT-coastlines - Coastline data for GMT


https://bugzilla.redhat.com/show_bug.cgi?id=438039





------- Additional Comments From pertusus at free.fr  2008-04-19 09:59 EST -------
Looks good. Both solutions seems right to me. I think that a provides
with lower case could be nice. Also I would have preferred lower case
package name, and provides with upper case, but it is up to you.

I had the following comment in my package, since I found it a bit difficult
to understand where the data comes from:

# seems to be derived at least from 2 Public Domain datasets, 
# CIA World DataBank II and World Vector Shoreline (already in fedora),
# then modified.

* rpmlint ignorable
GMT-coastlines-all.noarch: W: no-documentation
GMT-coastlines-full.noarch: W: no-documentation
GMT-coastlines-high.noarch: W: no-documentation
* free content, license included
* follow guidelines
* no %dist, but it is clearly the right choice for this arch independent
  big data
* %files section right
* match upstream


Needswork:

The source urls are wrong, there is no /4/ in the real urls.

Also the source files timestamps are not kept:
$ ls -l GSHHS1.9_* ../SOURCES/GSHHS1.9_*
-rw-r--r-- 1 dumas dumas  4249079 Oct 11  2007 ../SOURCES/GSHHS1.9_coast.tar.bz2
-rw-r--r-- 1 dumas dumas 29338515 Oct 11  2007 ../SOURCES/GSHHS1.9_full.tar.bz2
-rw-r--r-- 1 dumas dumas  8970004 Oct 11  2007 ../SOURCES/GSHHS1.9_high.tar.bz2
-rw-rw-r-- 1 dumas dumas  4249079 Apr  2 10:39 GSHHS1.9_coast.tar.bz2
-rw-rw-r-- 1 dumas dumas 29338515 Apr  2 10:39 GSHHS1.9_full.tar.bz2
-rw-rw-r-- 1 dumas dumas  8970004 Apr  2 10:39 GSHHS1.9_high.tar.bz2


Though it matches upstream:
3eda660b999ee888ff59f6c7eba209a6  GSHHS1.9_coast.tar.bz2
2d3064c3fa2f7a4c3a2603dbb9885fff  GSHHS1.9_full.tar.bz2
de50a3eab394393a7246f293ac0c840a  GSHHS1.9_high.tar.bz2


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.