[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693


mclasen at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From mclasen at redhat.com  2008-04-28 09:13 EST -------
Builds fine in mock. 

[mclasen at localhost Desktop]$ rpmlint
/var/lib/mock/fedora-9-i386/result/geoclue-*.rpm
geoclue-devel.i386: W: no-documentation
geoclue-gui.i386: W: no-documentation

Both of which are ignorable warnings.


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legibility: outstanding
upstream sources: ok
buildable: yes
excludearch: n/a
build deps: ok
locale handling: ok
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
content: permissible
documentation: the api docs should be moved to the -devel package
headers: ok
static libs: n/a
pkgconfig files: ok
shared libraries: ok
devel package: ok
libtool archives: ok
gui apps: n/a
file ownership: ok
%install: ok
utf8 filenames: ok


Approved, but please move the api docs to the -devel package.

I'll also note that the first attemot to run the test gui yields a segfault for
me, the second run succeeds. Something to look into...




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.