[Bug 456364] Review Request: pam_sotp - PAM module that provides support for One Time Passwords (OTP) authentication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pam_sotp - PAM module that provides support for One Time Passwords (OTP) authentication


https://bugzilla.redhat.com/show_bug.cgi?id=456364





------- Additional Comments From rakesh.pandit at gmail.com  2008-08-01 14:08 EST -------

Failed to Build
http://koji.fedoraproject.org/koji/taskinfo?taskID=753204 

--------------------------------------------------------
make[1]: Leaving directory `/builddir/build/BUILD/pam_sotp-0.3.3/src'
# PAM module
install -m 755 src/pam/pam_sotp.so
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/lib/security/
# OTPpasswd utility
install -m 2755 src/utils/otppasswd
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/usr/bin
# conf. files & directory
install -d -m 770  /builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/etc/sotp	
install -m 640  etc/pam.d/otppasswd
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/etc/pam.d/
+ /usr/bin/install -m 0644 -p
/builddir/build/SOURCES/pam_sotp-pam-config_include
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/etc/pam.d/otppasswd
+ /usr/bin/install -m 0644 -p /builddir/build/SOURCES/pam_sotp-README.RPM README.RPM
+ /usr/lib/rpm/find-debuginfo.sh --strict-build-id
/builddir/build/BUILD/pam_sotp-0.3.3
extracting debug info from
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/lib/security/pam_sotp.so
*** ERROR: No build ID note found in
/builddir/rpmbuild/BUILDROOT/pam_sotp-0.3.3-1.fc10.i386/lib/security/pam_sotp.so
error: Bad exit status from /var/tmp/rpm-tmp.OVLMHw (%install)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.OVLMHw (%install)
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps
builddir/build/SPECS/pam_sotp.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/mock/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.4/site-packages/mock/util.py", line 315, in do
    raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" %
(command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps
builddir/build/SPECS/pam_sotp.spec']
LEAVE do --> EXCEPTION RAISED
------------------------------------------------------------------------

You may like to check http://fedoraproject.org/wiki/Releases/FeatureBuildId
may be you need --build_id for ld at some place to fix it. 


It built on my system but failed on koji

rpmlint output gives:
pam_sotp.i386: W: non-conffile-in-etc /etc/pam.d/otppasswd
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

pam_sotp.i386: E: non-standard-dir-perm /etc/sotp 0770
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

pam_sotp.i386: E: setgid-binary /usr/bin/otppasswd root 02755
The file is setgid. Usually this is a packaging bug. If this is a game,  then,
you should use the proper rpm group, or location.

pam_sotp.i386: E: non-standard-executable-perm /usr/bin/otppasswd 02755
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

1 packages and 0 specfiles checked; 3 errors, 1 warnings.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.