[Bug 225855] Merge Review: gphoto2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225855


Jindrich Novy <jnovy at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Customer Facing|NO                          |---




--- Comment #9 from Jindrich Novy <jnovy at redhat.com>  2008-08-07 00:55:14 EDT ---
(In reply to comment #8)
> (In reply to comment #5)
> 
> Fedora tends to prefer %defattr(-,root,root,-)

Updated.

(In reply to comment #7)
> (In reply to comment #5)
> 
> + What is the need for two Source0 lines? The first one should be simply
> removed.

It was a typo, the older one should just have to go away.

> 
> + Unnecessary 'BuildRequires: pkgconfig' still remains.
> 

Removed.

> + You could look at Manuel's comment on simple-mtpupload, but its finally upto
> you.

Well, putting executable stuff into /usr/share/doc is not a good idea, we
should either package it to be actually executable in /usr/bin or not to
package it at all. Just removing the executable attribute to fool RPM is not a
solution IMO.

Thanks for the review :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.