[Bug 458238] Review Request: ibus - An input bus for Linux.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458238





--- Comment #4 from Parag AN(पराग) <panemade at gmail.com>  2008-08-08 00:53:52 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=765922
+ rpmlint is NOT silent for SRPM and for RPM.
ibus.i386: W: conffile-without-noreplace-flag /etc/X11/xinit/xinput.d/ibus.conf
==> Ok to accept.
+ source files match upstream url
48b73b6bfe056fa677ca57361149fa83  ibus-0.1.0.20080807.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ update-gtk-immodules scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files installed correctly.
+ Package  ibus-0.1.0.20080807-1.fc10 =>
Provides:
 config(ibus) = 0.1.0.20080807-1.fc10
 libibus-gtk.so.0
Requires:
 /bin/sh
 /usr/bin/env
 libX11.so.6
 libatk-1.0.so.0
 libc.so.6
 libc.so.6(GLIBC_2.0)
 libc.so.6(GLIBC_2.1.3)
 libc.so.6(GLIBC_2.3.4)
 libc.so.6(GLIBC_2.4)
 libcairo.so.2
 libdbus-1.so.3
 libdbus-glib-1.so.2
 libfontconfig.so.1
 libfreetype.so.6
 libgdk-x11-2.0.so.0
 libgdk_pixbuf-2.0.so.0
 libgio-2.0.so.0
 libglib-2.0.so.0
 libgmodule-2.0.so.0
 libgobject-2.0.so.0
 libgtk-x11-2.0.so.0
 libibus-gtk.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0
python(abi) = 2.5 rtld(GNU_HASH)

+ Package ibus-gtk-0.1.0.20080807-1.fc10 =>
  Provides: im-ibus.so
  Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.1.3) libcairo.so.2
libdbus-1.so.3 libdbus-glib-1.so.2 libfontconfig.so.1 libfreetype.so.6
libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0
libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libibus-gtk.so.0
libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 rtld(GNU_HASH)

+ Package ibus-qt-0.1.0.20080807-1.fc10 =>
Provides: libibus.so
Requires: libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libgcc_s.so.1
libgcc_s.so.1(GCC_3.0) libm.so.6 libpthread.so.0 libstdc++.so.6
libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.