[Bug 458457] Review Request: grc - GUI for GNURadio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458457





--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2008-08-08 12:39:20 EDT ---
Marek, thanks for the package.
Actual source file matches upstream.
Mock rebuild succeeded.
Offered functionality was tested.
RPMlint is mostly silent, see below
Uses macros consistently.

Have you thought about renaming the package to gnuradio-companion? That may
express the relation to gnuradio, and you'll prevent a potential name clash. It
even comes from the same upstream. Probably one day there'll be a lot of grc
packages around :)

0.) RPMLint thinks the package should be noarch

You do not ship any binaries. I do not know if the precompiled python stuff is
arch-independent -- probably worth trying.

Also, rpmlint complains about shebangs in nonexecutable files.

1.) Please do not create scripts inline in SPEC

That is utterly ugly. You should be ashamed.

2.) Fix your runtime dependencies.

You seem to import at least wx, gtk, pango, etc. We do not have autoreqs for
python. Please add the necessary Requires.

The upstream web [1] recommends the following, which you may want to base your
decision upon:

    * wx-python
    * numpy
    * gnuradio with gr-wxgui
    * python-gtk2(>=2.6)
    * python-xml and/or pyxml 

[1] http://gnuradio.org/trac/wiki/GNURadioCompanion

3.) License tag does not seem correct.

At least you include some CC blurb in %doc. Are you sure you don't ship any
Creative Commons stuff?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.