[Bug 458698] Review Request: libgdbus - D-Bus helper library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458698


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-08-12 01:32:22 EDT ---
Suggestions
1) remove following from %files
%{_libdir}/*.a
see
http://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries

2) Your build section should look like this
%configure --disable-static
make %{?_smp_mflags}

3) Add "Requires: pkgconfig" to devel package
>From Review Guidelines you can see
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).

4) rpmlint complain that 
libgdbus.i386: E: zero-length /usr/share/doc/libgdbus-0.1/NEWS
==> Remove NEWS from %docs

5) you should drop following line from SPEC
/sbin/ldconfig -n $RPM_BUILD_ROOT/%{_libdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.