[Bug 457888] Review Request: fwknop - A Single Packet Authorization (SPA) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457888


Adam Tkac <atkac at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |atkac at redhat.com




--- Comment #1 from Adam Tkac <atkac at redhat.com>  2008-08-12 06:40:34 EDT ---
I will take care about this review.

Specfile
---
- I think that daemons should be compiled with -fpie/-fPIE, shouldn't them?
(especially security related daemons)
- if you are going to put package only into rawhide please remove BuildRoot
definition (see http://wiki.rpm.org/Releases/4.5.90 - it is ignored)

----------------------------
rpmlint
---
src.rpm -> OK

binary rpm:
fwknop.x86_64: W: log-files-without-logrotate /var/log/fwknop
- would it be possible add logrotate script? It will prevent endless grow of
log file.

fwknop.x86_64: W: dangerous-command-in-%post perl
- this doesn't look right for me. I think that part of configuration file
should be changed by administrator, not by script (or simply put there
"localhost" in %install section of spec)

It would be nice to have SELinux policy for this package but if it not exists
yet I'm not going to block this review. Otherwise package seems fine for me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.