[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455555





--- Comment #13 from Oron Peled <oron at actcom.co.il>  2008-08-13 19:51:57 EDT ---
 * Updates:
   SRPM URL: http://oron.fedorapeople.org/libhocr/libhocr-0.10.13-3.fc8.src.rpm
   SPEC URL: http://oron.fedorapeople.org/libhocr/libhocr.spec

 * All new patches sent upstream.

> pkgconfig file issue
Fixed (also attached helper script in
 https://bugzilla.redhat.com/show_bug.cgi?id=455555#c12)

> ...and this means that -gtk subpackage Requires pygtk2-libglade
Fixed.

> This means that libhocr-gtk must have "Requires: pygtk2".
> is for libhocr-gtk, not for libhocr-python.
Fixed.

> * Desktop issue
>   - The Category "Application" is also deprecated and should be removed.
Fixed. Added a desktop-file-validate in %build to verify in the future.

>  - sane-pygtk.desktop contains:
>  ------------------------------------------------------------------
>  Icon=xsane
>  ------------------------------------------------------------------

Changed from 'xsane' to 'sane', we are now sure we have the icon: 
 * sane.png is included in sane-backends rpm (as well original tarball).
 * sane-backends is required by sane-backends-libs.
 * The libsane.so.1 contained in sane-backends-libs is required
   by python-imaging-sane.
 * python-imaging-sane is explicitly "Required" by libhocr-gtk
 * So installing libhocr-gtk would bring the icon as well.
QED ;-)

> The directory %_defaultdocdir/%name-%version is not owned by
> any packges.
Fixed.

> %build
> export CFLAGS="%optflags -Werror-implicit-function-declaration"
 * Added to .spec and fixed the code.
 * Also fixed a bunch of 'unused variable' warnings.
 * While doing this, I noticed the code contains tons of duplication.
   I offered Kobi (upstream author) some help in refactoring this code
   and wait for his reply (don't want to step on his feet).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.