[Bug 459549] Review Request: python-ethtool - bindings for the ethtool kernel interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459549





--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-19 23:14:04 EDT ---
A few comments:

  python-ethtool.x86_64: E: non-standard-executable-perm 
   /usr/lib64/python2.5/site-packages/ethtool.so 0775
This should probably not be group-writable.

  python-ethtool.x86_64: W: summary-not-capitalized ethtool python bindings
Kind of self-explanatory.

  python-ethtool.x86_64: W: incoherent-version-in-changelog 0.1-3 0.2-1.fc10
You should have a changelog entry matching every version you release.

  python-ethtool.x86_64: W: no-url-tag
Is there really no upstream for this package?  It is very strongly suggested
that there be an independent upstream source for everything in Fedora.

Is the license really GPLv2+?  The source would seem to indicate GPLv2 only.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.