[Bug 459535] Review Request: backup-manager

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 20 16:33:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459535


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com




--- Comment #1 from Remi Collet <fedora at famillecollet.com>  2008-08-20 12:33:26 EDT ---
I will be away for the next few days, so only small comments.

1/ I don't know if using same file for input/ouput in iconv is a good idea.

2/ Keeping the original date/time of documentation file is probably a good idea
(no guidelines about this, I think, but some reviewer ask for it)

A simple solution (1+2) :

     # Convert to utf-8
     for file in AUTHORS ChangeLog THANKS; do
       mv $file timestamp
       iconv -f ISO-8859-1 -t UTF-8 -o $file timestamp
       touch -r timestamp $file
     done

3/ Should provides a working config.

Especialy, the BM_REPOSITORY_ROOT (should be configured, created and owned by
the RPM).

4/ Cron integration

It could be useful to provided a cron.daily script with the RPM, with log
stored in the usual folder (and of course a logrotate config)

=> Yum install and forget it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list