[Bug 458685] Review Request: R2spec - Python script to generate R spec file

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 20 20:31:46 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458685





--- Comment #19 from R P Herrold <herrold at owlriver.com>  2008-08-20 16:31:44 EDT ---
As a matter of good programming style, it would be helpful to maintain a
CHANGELOG file, or to complete %changelog stanza entries outlining what was
done coming into a new tarball -- a version control system (something as simple
and lightweight as RCS, or something more formal) will do this for you.

As near as I can make out, there was a path issue (which you cured with a
swap), and an addition of a temporary file naming convention (which does NOT
check for a collision, and so is potentially unsafe -- I would add a check
there).

-- Russ herrold

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list