[Bug 456298] Review Request: netbeans-resolver - Resolver subproject of xml-commons patched for NetBeans

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456298





--- Comment #4 from Victor G. Vasilyev <victor.vasilyev at sun.com>  2008-08-22 12:35:04 EDT ---
The third release is prepared for review.
Spec URL:
http://nbi.netbeans.org/files/documents/210/2050/netbeans-resolver.spec
SRPM URL:
http://nbi.netbeans.org/files/documents/210/2146/netbeans-resolver-6.1-3.fc10.src.rpm

FYI a page with all resources related to the NetBeans here:
http://nbi.netbeans.org/servlets/ProjectDocumentList?folderID=267

(In reply to comment #3)
>  o please remove or explain the distribution tag.
- Redundant distribution tag is removed

>  o I don't see the need for the %nb_ and %nb_ver macros
>  o why define orig_jar, ijardir br_jardir
- Redundant user-defined macros are removed

>  o add the -k option to dos2unix to preserve timestamps
- The -k option is used for the dos2unix commands

>  o switch from  $RPM_BUILD_ROOT to %{buildroot} everywhere.
- The %%{buildroot} is used everywhere instead of $RPM_BUILD_ROOT

Also, it is additionally fixed:
- java-devel is specified in BuildRequires insead of java-1.6.0-openjdk
- An epoch of 1 is included in the requirements for the Java versions
- The canonical RPM macros are used instead of the commands ant and rm
- More correct source URL is used, i.e not a mirror

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.