[Bug 443675] Review Request: sip-redirect - Tiny IPv4 and IPv6 SIP redirect server written in Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=443675





--- Comment #6 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-23 07:31:57 EDT ---
Notes:

* Please, provide full path to the source tarball. E.g.
Source: http://ftp.robert-scheck.de/linux/%{name}/%{name}-%{version}.tar.gz
instead of
Source: %{name}-%{version}.tar.gz

* Please, add empty %build section to make rpmlint happy :)

* Use %{_initrddir}  instead of %{_sysconfdir}/rc.d/init.d 
BTW useful list of rpm-macros:
  https://fedoraproject.org/wiki/Packaging/RPMMacros

Other things seems sane. Consider applying changes according to these advices,
and I'll made formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.