[Bug 454462] Review Request: ksplice - Patching a Linux kernel without reboot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454462





--- Comment #17 from Thomas Moschny <thomas.moschny at gmx.de>  2008-08-24 04:47:13 EDT ---
First of all, sorry for the delay.

Second, I guess you meant
http://www.herr-schmitt.de/pub/ksplice/ksplice-0.8.7-11.fc9.src.rpm,
used that for the following review.

[x] = ok, [~] = ok - see note, [!] = not ok, [-] = not applicable

[x] package meets naming guidelines
[x] specfile is encoded in ascii or utf-8
[x] specfile matches base package name
[x] specfile uses macros consistently
[x] specfile is written cleanly
[x] specfile is written in AE
[x] changelog is present and has correct format
[x] license matches actual license
[x] license is open source-compatible
[x] license text is included in package
[x] source tag has correct url
[x] source files match upstream

    md5sum: 4e42c5a72f4734256db8b50290f1b7a1

[x] latest version is packaged
[x] summary is concise
[x] dist tag is present
[x] buildroot is correct
[x] buildroot is prepped
[x] %clean is present
[x] proper build requirements
[x] proper requirements
[x] uses %{?_smp_mflags}
[x] uses %{optflags}
[x] doesn't use %makeinstall
[x] package builds at least on one architecture

    tested on: f9/x86_64

[!] packages installs and runs at least on one architecture

    - Upon installation:
    error: Failed dependencies:
           rpmbuild is needed by fedora-ksplice-0.8.7-11.fc9.x86_64

    - More problems running fedora-ksplice-prepare, see later.

[!] rpmlint is quiet

    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/helper.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/helper.c
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/primary.c
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/modcommon.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/jumps.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/modcommon.c
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/primary.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/nops.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/allcommon.h
    ksplice.x86_64: W: devel-file-in-non-devel-package
/usr/share/ksplice/kmodsrc/allcommon.c

    -> This has been discussed before.

    ksplice.src:95: E: files-attr-not-set
    ksplice.src: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab: line 1)
    ksplice.src: W: strange-permission fedora-ksplice-create 0775
    ksplice.src: W: strange-permission fedora-ksplice-prepare 0775

    -> Please fix these.

[!] final provides/requires look sane

    - ksplice misses a dependency on util-linux-ng (for /bin/dmesg)
    - for fedora-ksplice, 'rpmbuild' cannot be satisfied

[-] ldconfig called in %post and %postun if required
[x] code, not content
[x] file permissions are appropriate
[x] debuginfo package looks usable
[-] config files marked as %config(noreplace)
[x] owns all the directories it creates
[-] static libraries in -devel subpackage
[-] header files in -devel subpackage
[-] development .so files in -devel subpackage
[-] pkgconfig files in -devel subpackage, requires pkgconfig
[x] no .la files
[x] doesn't need a -docs subpackage
[x] relevant docs are included
[x] doc files are not needed at runtime
[-] provides a .desktop file, build-requires desktop-file-utils
[-] uses %find_lang, build-requires gettext


Problems running fedora-ksplice-prepare:

- /usr/bin/fedora-ksplice-prepare: line 73: trap: -: invalid signal
  specification

- fedora-ksplice-prepare tries to cd into
  BUILD/kernel-2.6/linux-2.6.x86_64 here, correct dir would be
  BUILD/kernel-2.6.25/linux-2.6.25.x86_64.

- fedora-ksplice-prepare always re-downloads the (40MB)
  kernel.src.rpm, should probably be cached.


In my opinion, these (and probably more) problems of the scripts can
unnecessarily block approval of the ksplice package.

One solution would be to move them to another package (maybe creating
a tiny fedorhosted project) instead of a subpackage and adding a small
README instead, that describes how ksplice can be used in fedora. This
way (after fixing the minor problems shown in the review) ksplice
itself could be approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.