[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450243





--- Comment #18 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-28 02:55:26 EDT ---
For 0.10.1-2:

* About rpath/linking issue
---------------------------------------------------------------------
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool

# Set LD_LIBRARY_PATH: desktop file creation requires access to the libraries
# which have not been installed
export LD_LIBRARY_PATH=`pwd`/ggadget/.libs
---------------------------------------------------------------------
  - Well, actually the reason you have to set LD_LIBRARY_PATH temporarily
    is that you killed rpath completely even on build stage under builddir
    by the two lines above.
    Usually removing rpath by this way just "breaks" libtool and especially
    when the package has its own library path (like %_libdir/%name or so)
    linking fails like this way.

    The reason this package adds standard rpath is
    - When linking libtool tries to find out standard libraries only
      from /usr/lib and /lib, so on 64 bits architectures the unsearched
      /usr/lib64 or so is added as rpath.
      (Fedora libtool on 64 bits actually searches libraries also from
       /usr/lib64 and so on. You can check this by the diff of %_bindir/libtool
       (this is bash script) on i386 and x86_64 archs)
      Note that libtool is created from configure
    - hosts/*/Makefile.in has unneeded -R$(libdir) :(

    So I recommend:
----------------------------------------------------------------------
%prep
%setup -q -n %{name}-for-linux-%{version}
# Permission fixes
chmod -x ggadget/qt/utilities.h

# Rpath issue
# Add library search path
sed -i.libdir_syssearch -e \
  '/sys_lib_dlsearch_path_spec/s|/usr/lib |/usr/lib /usr/lib64 /lib /lib64 |' \
  configure
# No!! No!!
sed -i.extra_R -e \
 's|-R\$(libdir)||' \
 hosts/*/Makefile.in
----------------------------------------------------------------------

* Timestamp issue
  - As said above, would you consider to use the following?
----------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT \
 INSTALL="install -p" CPPROG="cp -p"
----------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.