[Bug 460387] Review Request: python-schedutils - bindings for the scheduler settings interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460387





--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2008-08-29 03:46:45 EDT ---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=792532
+ rpmlint is silent for SRPM and for RPM.
- source file md5 checksum from SRPM is
2e94101218ac254974d836b82a476b64  python-schedutils-0.2.tar.bz2
from upstream is
de268b04b767df4214f61c72fac51007  python-schedutils-0.2.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Package python-schedutils-0.2-2.fc10 =>
Provides: schedutils.so
Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5
rtld(GNU_HASH)

Suggestions:
1)from review guidelines
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the  Source URL
Guidelines for how to deal with this.
==> Resubmit SRPM with same tarball inside SRPM and upstream source URL in
SPEC.

2) Not mandatory but you can use defattr as
%defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.