[Bug 460615] Review Request: bti - Bash Twitter Idiocy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460615





--- Comment #3 from Peter Lemenkov <lemenkov at gmail.com>  2008-08-29 07:03:01 EDT ---
REVIEW:

+ rpmlint is silent.
+ The package is named according to the Package Naming Guidelines.
+ The spec file matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The text of the license(s) is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[petro at Sulaco SOURCES]$ md5sum bti-005.tar.bz2*
65466367d82bae9b470bcf6591bdf37f  bti-005.tar.bz2
65466367d82bae9b470bcf6591bdf37f  bti-005.tar.bz2.orig
[petro at Sulaco SOURCES]$

+ The package successfully compiles and builds into binary rpms on at least one
supported architecture (ppc).
+ All build dependencies are listed in BuildRequires.
+ The package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros, as described in the macros section of
Packaging Guidelines .
+ The package contains code, or permissable content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in rpm package are valid UTF-8.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.